Skip to content

Set up CMake build for extension/evalue_util #12691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 74 commits into from
Jul 23, 2025
Merged

Set up CMake build for extension/evalue_util #12691

merged 74 commits into from
Jul 23, 2025

Conversation

swolchok
Copy link
Contributor

It didn't have one. Now it does.

swolchok added 30 commits July 13, 2025 09:47
@swolchok
Update
9e3e2e7 
[ghstack-poisoned]
@swolchok
forgot to amend
16f0274 
[ghstack-poisoned]
@swolchok
Update
99ec5a7 
[ghstack-poisoned]
@swolchok
Update
ff3cdb9 
[ghstack-poisoned]
@swolchok
Update
513de13 
[ghstack-poisoned]
@swolchok
Update
76db1f1 
[ghstack-poisoned]
@swolchok
Update
08bffac 
[ghstack-poisoned]
@swolchok
Update
dff96c8 
[ghstack-poisoned]
@swolchok
Update
0e2bce6 
[ghstack-poisoned]
@swolchok
Update
35d8319 
[ghstack-poisoned]
@swolchok
Update
a31187e 
[ghstack-poisoned]
@swolchok
Update
dcbce0d 
[ghstack-poisoned]
@swolchok
Update
bc8f971 
[ghstack-poisoned]
@swolchok
Update
29d3999 
[ghstack-poisoned]
@swolchok
Update
7e4040a 
[ghstack-poisoned]
@swolchok
Update
2dacf6f 
[ghstack-poisoned]
@swolchok
Update
fb2b775 
[ghstack-poisoned]
@swolchok
Update
02f19a6 
[ghstack-poisoned]
@swolchok
Update
225d5a6 
[ghstack-poisoned]
@swolchok
Update
41bf264 
[ghstack-poisoned]
@swolchok
Update
f54a8ce 
[ghstack-poisoned]
@swolchok
Update
e48e6cc 
[ghstack-poisoned]
@swolchok
Update
a2f14ac 
[ghstack-poisoned]
@swolchok
Update
c31a4b9 
[ghstack-poisoned]
@swolchok
Update
4fd7372 
[ghstack-poisoned]
@swolchok
Update
d650396 
[ghstack-poisoned]
@swolchok
Update
3bfdade 
[ghstack-poisoned]
@swolchok
Update
00acd77 
[ghstack-poisoned]
@swolchok
Update
6946143 
[ghstack-poisoned]
@swolchok
Update
431ddd8 
[ghstack-poisoned]
@swolchok swolchok added ciflow/trunk ciflow/binaries/all Release PRs with this label will build wheels for all python versions labels Jul 22, 2025
@swolchok
Copy link
Contributor Author

arm-cortex-m-size-test appears to have failed more than once now with

In file included from /pytorch/executorch/extension/data_loader/mmap_data_loader.cpp:19:
/pytorch/executorch/extension/data_loader/../../../executorch/extension/data_loader/mman.h:18:10: fatal error: sys/mman.h: No such file or directory
18 | #include <sys/mman.h>

puzzling, will have to investigate. other tests are looking pretty good; test-llama-runner-mac (fp32, coreml) looks like it's probably either a flake or a different PR because it's an output change, which this PR really should not cause.

@swolchok
Copy link
Contributor Author

will have to investigate.

repros on previous PR #12678

does not repro on #12667.

Moving investigation to #12678

swolchok added 7 commits July 22, 2025 15:09
@swolchok
Update
3d760e0 
[ghstack-poisoned]
@swolchok
Update
ae4ac22 
[ghstack-poisoned]
@swolchok
Update
9e04e6a 
[ghstack-poisoned]
@swolchok
Update
fa557ca 
[ghstack-poisoned]
@swolchok
Update
5173bf2 
[ghstack-poisoned]
@swolchok
Update
e6c83db 
[ghstack-poisoned]
@swolchok
Update
8978c19 
[ghstack-poisoned]
This was referenced Jul 23, 2025
Merged
Merged
@swolchok
Copy link
Contributor Author

test-llama-runner-mac (fp32, coreml) is still failing! very strange

@swolchok
Copy link
Contributor Author

test-models-linux-basic mv3 failure https://github.com/pytorch/executorch/actions/runs/16456606096/job/46515099970?pr=12691 failure looks like an infra flake

test-llama-runner-mac (fp32, coreml) is still failing! very strange

failure does not repro locally

swolchok added 6 commits July 23, 2025 11:07
@swolchok
Update
1cf3567 
[ghstack-poisoned]
@swolchok
Update
b0d965c 
[ghstack-poisoned]
@swolchok
Update
d9bf112 
[ghstack-poisoned]
@swolchok
Update
7852f9a 
[ghstack-poisoned]
@swolchok
Update
5f9f7c5 
[ghstack-poisoned]
@swolchok
Update
bdabc9c 
[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

test-llama-runner-mac (fp32, coreml) is still failing! very strange

failure does not repro locally

passing now, must've been some weird transient issue

swolchok added 2 commits July 23, 2025 15:16
@swolchok
Update
a9dadf4 
[ghstack-poisoned]
@swolchok
Update
707e40f 
[ghstack-poisoned]
Base automatically changed from gh/swolchok/524/head to main July 23, 2025 23:29
@swolchok
Copy link
Contributor Author

merging based on previous good CI run

@swolchok swolchok merged commit cfefd2c into main Jul 23, 2025
244 of 478 checks passed
@swolchok swolchok deleted the gh/swolchok/525/head branch July 23, 2025 23:30
Conarnar pushed a commit to Conarnar/executorch that referenced this pull request Jul 25, 2025
@swolchok @Conarnar
Set up CMake build for extension/evalue_util (pytorch#12691)
9112fd6 
It didn't have one. Now it does.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GregoryComer GregoryComer GregoryComer approved these changes

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820 larryliu0820 is a code owner

@kirklandsign kirklandsign Awaiting requested review from kirklandsign kirklandsign is a code owner

@shoumikhin shoumikhin Awaiting requested review from shoumikhin shoumikhin is a code owner

Assignees
No one assigned
Labels
ciflow/binaries/all Release PRs with this label will build wheels for all python versions ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@swolchok @GregoryComer @facebook-github-bot